Skip to content

Conversation

@mandli
Copy link
Member

@mandli mandli commented Feb 7, 2025

This is another attempt at moving over to pytests following from #279. It also attempts to move the tests into their corresponding directories. If there is not one, then a new example will be created that matches it.

@mandli mandli added the testing label Feb 7, 2025
@mandli mandli marked this pull request as draft February 7, 2025 14:36
@mandli mandli self-assigned this Feb 7, 2025
@mandli mandli requested review from mjberger and rjleveque February 7, 2025 14:37
This test greatly resembles the inflow example but needed additional source to
run with the correct behavior.  This has been maintained with some modifications
to the Makefile and executable building in the test code.
@mandli
Copy link
Member Author

mandli commented Apr 18, 2025

Note that the adjoint test is currently failing with

FAILED examples/acoustics_2d_adjoint/test_acoustics_2d_adjoint_flagging.py::Acoustics2DAdjointFlaggingTest::runTest - ValueError: operands could not be broadcast together with shapes (55,) (51,)

I am not sure why but at some point later in the run the gauges diverge. Perhaps a regression? Looks ok to me.

@mandli
Copy link
Member Author

mandli commented Apr 21, 2025

All tests have not been implemented but both adjoint tests are failing. There are some inconsistencies in the 1D test that I have not puzzled out yet but everything seems to run. Someone familiar with the adjoint code may need to look into what is going on there.

@mandli mandli marked this pull request as ready for review April 21, 2025 15:28
@mandli mandli changed the title WIP: Switch to PyTest Switch to PyTest Apr 21, 2025
@mandli
Copy link
Member Author

mandli commented May 6, 2025

Woot! It's working!

@mandli mandli merged commit ad97c9e into clawpack:master Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant