Open
Conversation
Owner
|
Thanks for doing this, I'll try to take a look soon. I haven't looked, yet, but I suspect this will require station owners who are up and running with the current plugin to change their station type on the Windguru side? If so, this probably warrants a clear "breaking change" notice in the README. |
Author
|
No need to change the station type, it's been working nicely with 60s interval updates here: https://www.windguru.cz/station/3609 - the station is setup as normal weewx type |
Author
|
you should merge it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windguru published some API docs and I went ahead and switched to those.
There were actually some bugs that were fixed along the way. The main change is that we now use their
salt+station+passMD5 hash as auth.Some bug fixes:
One observation: windguru seems a lot happier with more frequent updates, so I added the config parameter for 60s updates to the readme by default.
Also went ahead and mentioned the UID/Station ID thing that was suggested in #2, so this Closes #2 if merged.