Icon helper #16
Merged
Icon helper #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a level of abstraction to the existing `glyphicon` helper, allowing
users to select a different vector icons library. For instance, it is
now possible to display Font Awesome icons by passing the library option:
<%= icon :heart, library: :font_awesome %>
Note that, since Font Awesome CSS is not loaded by default with Bootstrap
CSS, it's up to the user to make sure the CSS is loaded in the same app.
Since the `icon` helper accepts `library: :font_awesome`, and the Font Awesome CSS is not loaded by default by Bootstrap CSS, it is helpful to have an additional CDN helper, so people who want to include Font Awesome icons can simply write: ```rhtml <%= stylesheet_link_tag font_awesome_css %> <%= icon :heart, library: :font_awesome %> ```
claudiofullscreen
force-pushed
the
icon-helper
branch
from
c9ffc58 to
22a6813
Compare
|
+1 |
Contributor
|
@cladiofullscreen how would you like me to integrate this with #15, straight merge? |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @buren ! This PR stems from #14 – let me tell you what I've changed:
:classoption, such as<%= icon :heart, library: :font_awesome, class: 'fa-2x' %>…font_awesome_csshelper to CDN, so it's even easier to use Font Awesome icons.If it all looks good to you, I'll merge and add the appropriate documentation to http://fullscreen.github.io/bh
Thanks again for the idea and the coding!!