Skip to content

Conversation

@donatj
Copy link

@donatj donatj commented Aug 12, 2024

This destructor isn't actually doing anything because the local variables $clientId and $clientSecret are not defined in this scope.

I think the code intends to be doing the following

        function __destruct()
        {
            unset($this->clientId);
            unset($this->clientSecret);
        }

but that shouldn't be necessary, because the members attached to the class will be unset immediately following destruction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant