Open
Conversation
ad2628e to
fd3ea53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a case where a customer has a different naming convention for their AWS profiles, so this configuration will work for them but not us:
This PR allows setting the profile name with an environment variable (we'll use direnv) and if it's not set then it will fallback to the other profile name.
The configuration file will look something like this:
If both users have direnv, then we'll need to put some logic into the
.envrcfile to conditionally set thisPRODUCTION_AWS_PROFILEenvironment variable. One option is to grep~/.aws/configfor the profile name that we want to use.