Refactor: Address Code Smells #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract KeyboardSettings and HapticSettings from KeyboardViewModel
- Eliminates duplicate didSet handlers for haptic intensity properties
- Centralizes settings persistence logic
- Adds SettingsKey enum for type-safe UserDefaults keys
- Extract HapticFeedbackManager from KeyboardViewModel
- Separates haptic feedback concern from keyboard state management
- Cleaner API: tap(), modifier(), drag() methods
- Add Vector2D type for geometric calculations
- Type-safe 2D vector operations (dot, cross, angle, etc.)
- Improves code readability in gesture processing
- Add GestureFeatureCalculations helper functions
- Extracted from GestureFeatures.extract() for better testability
- Pure functions for pathLength, centroid, circularity, etc.
- Add KeyBuilder pattern for MessagEase key definitions
- Fluent API for building key configurations
- Reduces boilerplate in KeyboardLayout.swift
- Example: KeyBuilder("a").swipe(.up, "ä").build(locale: de)
- Fix force unwraps in GesturePreprocessor
- Replace force unwraps with optional binding
- Safer handling of edge cases
- Document magic numbers in KeyboardConstants
- Added documentation explaining purpose of each constant
- e.g., minSwipeLength: 30pt ≈ 55% of key height
- Refactor GestureFeatures.extract() to use GestureCalculations - Reduces method from ~165 lines to ~55 lines - All calculations now delegated to testable helper functions - Add GeometryUtils.swift for centralized CGPoint extensions - distance(to:), magnitude(), asVector, vector(to:) - Removes duplicate definitions from KeyboardLayout.swift and Vector2D.swift - GestureCalculations now properly uses Vector2D - angularSpan() and turnConsistency() use Vector2D for cleaner math
Tests for Vector2D, GestureCalculations, KeyboardSettings, KeyBuilder, and GeometryUtils - all 160+ tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HapticSettingsandLayoutSettingsclassesHapticFeedbackManagerto separate haptic feedback concernVector2Dtype for type-safe geometric calculationsGestureCalculationsenumKeyBuilderfluent API for MessagEase key definitionsGeometryUtilsGesturePreprocessorKeyboardLayoutNew Files
KeyboardSettings.swiftHapticFeedbackManager.swiftVector2D.swiftGestureFeatureCalculations.swiftKeyBuilder.swiftGeometryUtils.swiftTest Coverage
Added 5 new test files with 50+ test cases covering all new components:
Vector2DTests.swiftGestureCalculationsTests.swiftKeyboardSettingsTests.swiftKeyBuilderTests.swiftGeometryUtilsTests.swiftTest plan