Skip to content

remove iconv fallback code for ruby 1.8 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckruse merged 1 commit into from
Nov 14, 2025
Merged

remove iconv fallback code for ruby 1.8 #69

ckruse merged 1 commit into from
Nov 14, 2025

Conversation

@wtn
Copy link
Contributor

@wtn wtn commented Nov 14, 2025

Removes dead Iconv fallback code that was only needed for Ruby 1.8, which is no longer supported.

Changes

  • Simplify Binary.charset_convert to always use String#encode
  • Simplify Binary.charset_strlen to remove Iconv fallback path
  • Remove conditional checks for respond_to?(:encode)

@wtn @claude
remove iconv fallback code for ruby 1.8
5df2924 
Co-authored-by: Claude <noreply@anthropic.com>
@ckruse ckruse merged commit a086208 into ckruse:master Nov 14, 2025
10 checks passed
@wtn wtn deleted the iconv branch November 14, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wtn @ckruse