feat: add document management via admin web interface #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability for admins to upload, delete, and list documents through the web UI. Documents are stored on filesystem with metadata in SQLite. Key features: - Upload .md/.txt files (max 1 MB, limit 20 documents) - Auto-extract title from content - Delete with confirmation (triggers full reindex due to ChromaDB limitation) - List uploaded documents with metadata (title, type, size, upload date) - Separate sections for uploaded vs static documents Security: - Path traversal prevention with robust filename validation - File size validation before reading into memory - Document count limit to prevent abuse - Sanitized logging to prevent log injection Also fixes pre-existing bandit findings: - B104: Add nosec for intentional 0.0.0.0 binding - B106: Add nosec for OAuth2 "bearer" token type - B704: Add nosec for bleach-sanitized Markup
The .gitignore pattern 'documents/' was matching src/modules/documents/. Changed to '/documents/' to only match root documents folder.
Add 31 tests covering: - Document model and from_row deserialization - DocumentRepository CRUD operations - DocumentService upload, delete, list operations - Validation (size, extension, filename, document limit) - Exception handling and error cases Restores coverage to 80%+ (was 75% without tests).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Features
Security
Architecture
documentsmodule following clean architecture patterndocumentstableTest plan
/pre-commit- all checks pass