fix: resolve NoActiveWorker error in TUI workspace removal#34
Merged
Conversation
Add @work() decorator to action_remove method to provide required worker context for push_screen_wait() async operation. The decorator enables Textual's message pump to properly suspend and resume the async action when displaying the confirmation modal. Fixes: NoActiveWorker exception when pressing 'd' key in TUI Impact: Workspace removal via TUI now works correctly Changes: - Add 'from textual import work' import - Add @work() decorator to action_remove method
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
NoActiveWorkerexception that occurred when attempting to remove workspaces via the TUI (pressing 'd' key).Root Cause
The
action_remove()method callspush_screen_wait()which requires running in a worker context. Action handlers triggered by keybindings run in the main event loop by default, not in a worker.Solution
Added the
@work()decorator toaction_remove()to ensure it runs in a worker context, which is required by Textual'spush_screen_wait()method.Changes
from textual import work@work()decorator to theaction_removemethodTesting
Verification
To test the fix:
ags tuidto remove