Open
Conversation
fix sbom source interface syft
wip cosign source implementation wip cosign wip cosign
run go tidy
bugfix
github-actions
bot
added
the
size/XXL
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #833 +/- ##
===========================================
- Coverage 25.13% 11.03% -14.10%
===========================================
Files 6 16 +10
Lines 565 1450 +885
===========================================
+ Hits 142 160 +18
- Misses 406 1267 +861
- Partials 17 23 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR introduces the ability to retrieve SBOMs from Cosign attestations and refactors the SBOM source logic to support multiple sources, closing #805 .
It abstracts the SBOM generation and retrieval process behind a new SBOMSource interface, allowing for greater flexibility and the addition of new sources like Cosign alongside the existing Syft integration.
Note 1 I have currently hardcoded the predicate type of the Cosign source to
cyclonedx. Cosign would support different options but I was unsure how to model this in the configuration parameters and whether or not it was actually needed.Note 2: I have created a
sourcesfolder and moved thesyftfolder into it hence the big change. I can revert this if you want but I think it makes sense to have sources of syft and cosign in a folder.Best regards