Skip to content

Comments

Create unique DT-projects per k8s cluster#823

Open
salvabot0001 wants to merge 3 commits intockotzbauer:mainfrom
salvabot0001:dt-common-prefix
Open

Create unique DT-projects per k8s cluster#823
salvabot0001 wants to merge 3 commits intockotzbauer:mainfrom
salvabot0001:dt-common-prefix

Conversation

@salvabot0001
Copy link

@salvabot0001 salvabot0001 commented Jan 7, 2026

Changelog

Add support for kubernetesClusterIdMode configuration in DependencyTrack integration

This solves #822

@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 7, 2026
@salvabot0001 salvabot0001 changed the title #822 Create unique DT-projects per k8s cluster Create unique DT-projects per k8s cluster Jan 7, 2026
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.54%. Comparing base (09054d3) to head (edd2343).
⚠️ Report is 282 commits behind head on main.

Files with missing lines Patch % Lines
internal/target/dtrack/dtrack_target.go 0.00% 7 Missing ⚠️
internal/processor/processor.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #823       +/-   ##
===========================================
- Coverage   25.13%   11.54%   -13.59%     
===========================================
  Files           6       13        +7     
  Lines         565     1386      +821     
===========================================
+ Hits          142      160       +18     
- Misses        406     1203      +797     
- Partials       17       23        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckotzbauer
Copy link
Owner

Hi @salvabot0001,
thanks for opening this PR. As the new KubernetesCommonPrefix is very similar to the existing KubernetesClusterId I would prefer to not introduce a new flag with a similar purpose. I would suggest to introduce another flag DtrackKubernetesClusterIdMode instead or similar named which has two possible values: tag (default) and prefix. tag would preserve the current handling inside the dtrack_target.go were the cluster-id is used as project-tag. The new prefix mode could be used instead of tagging for the prefixing you introduced.
WDYT?

@salvabot0001
Copy link
Author

Hi @ckotzbauer,

thanks for the fast reply. I agree with you here. I will adjust the PR with your suggestion.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants