Skip to content

Fix Non-GPS Messages #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hpuhr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Non-GPS Messages #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c721f4d
removed superflous line breaks and carriage returns
hpuhr Sep 18, 2023
fc5620b
added other service messages than GP
hpuhr Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions src/GPSService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,62 @@ void GPSService::attachToParser(NMEAParser& _parser){
this->read_GPVTG(nmea);
});

// https://anavs.com/knowledgebase/nmea-format/

// * GP for GPS only solutions
// * GL for GLONASS only solutions
// * GA for GALILEO only solutions
// * GN for multi GNSS solutions


_parser.setSentenceHandler("GLGGA", [this](const NMEASentence& nmea){
this->read_GPGGA(nmea);
});
_parser.setSentenceHandler("GLGSA", [this](const NMEASentence& nmea){
this->read_GPGSA(nmea);
});
_parser.setSentenceHandler("GLGSV", [this](const NMEASentence& nmea){
this->read_GPGSV(nmea);
});
_parser.setSentenceHandler("GLRMC", [this](const NMEASentence& nmea){
this->read_GPRMC(nmea);
});
_parser.setSentenceHandler("GLVTG", [this](const NMEASentence& nmea){
this->read_GPVTG(nmea);
});

_parser.setSentenceHandler("GAGGA", [this](const NMEASentence& nmea){
this->read_GPGGA(nmea);
});
_parser.setSentenceHandler("GAGSA", [this](const NMEASentence& nmea){
this->read_GPGSA(nmea);
});
_parser.setSentenceHandler("GAGSV", [this](const NMEASentence& nmea){
this->read_GPGSV(nmea);
});
_parser.setSentenceHandler("GARMC", [this](const NMEASentence& nmea){
this->read_GPRMC(nmea);
});
_parser.setSentenceHandler("GAVTG", [this](const NMEASentence& nmea){
this->read_GPVTG(nmea);
});


_parser.setSentenceHandler("GNGGA", [this](const NMEASentence& nmea){
this->read_GPGGA(nmea);
});
_parser.setSentenceHandler("GNGSA", [this](const NMEASentence& nmea){
this->read_GPGSA(nmea);
});
_parser.setSentenceHandler("GNGSV", [this](const NMEASentence& nmea){
this->read_GPGSV(nmea);
});
_parser.setSentenceHandler("GNRMC", [this](const NMEASentence& nmea){
this->read_GPRMC(nmea);
});
_parser.setSentenceHandler("GNVTG", [this](const NMEASentence& nmea){
this->read_GPVTG(nmea);
});
}


Expand Down
18 changes: 15 additions & 3 deletions src/NMEAParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,8 @@ void NMEAParser::parseText(NMEASentence& nmea, string txt){
sz << "Found " << nmea.parameters.size() << " parameters.";
onInfo(nmea, sz.str());

string tmp_str;

//possible checksum at end...
size_t endi = nmea.parameters.size() - 1;
size_t checki = nmea.parameters[endi].find_last_of('*');
Expand All @@ -450,7 +452,17 @@ void NMEAParser::parseText(NMEASentence& nmea, string txt){
onError(nmea, "Checksum '*' character at end, but no data.");
}
else{
nmea.checksum = last.substr(checki + 1, last.size() - checki); //extract checksum without '*'

//extract checksum without '*' and \n,\r

// copy into temporary string
tmp_str = last.substr(checki + 1, last.size() - checki);

// remove superflous line breaks and carriage returns
tmp_str.erase(std::remove(tmp_str.begin(), tmp_str.end(), '\n'),tmp_str.end());
tmp_str.erase(std::remove(tmp_str.begin(), tmp_str.end(), '\r'),tmp_str.end());

nmea.checksum = tmp_str;

onInfo(nmea, string("Found checksum. (\"*") + nmea.checksum + "\")");

Expand All @@ -461,10 +473,10 @@ void NMEAParser::parseText(NMEASentence& nmea, string txt){
}
catch( NumberConversionError& )
{
onError(nmea, string("parseInt() error. Parsed checksum string was not readable as hex. (\"") + nmea.checksum + "\")");
onError(nmea, string("parseInt() error. Parsed checksum string was not readable as hex. (\"") + nmea.checksum + "\")");
}

onInfo(nmea, string("Checksum ok? ") + (nmea.checksumOK() ? "YES" : "NO") + "!");
onInfo(nmea, string("Checksum ok? ") + (nmea.checksumOK() ? "YES" : "NO") + "!");


}
Expand Down