fix: fixing log forging vulnerability#7
Open
Farenheith wants to merge 1 commit intockanthony:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 61.63% 61.59% -0.04%
==========================================
Files 6 7 +1
Lines 1251 1268 +17
==========================================
+ Hits 771 781 +10
- Misses 404 411 +7
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adding sanitization to log to avoid log forging vulnerability from user interaction
121c8b9 to
4b7a4e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding sanitization to log to avoid log forging
vulnerability from user interaction.
Problem description:
The program writes unvalidated user input to log. An attacker could take advantage of this behavior to forge log entries or inject malicious content into the log.