Skip to content

Allow Blkaclisting URLs from config #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zelima wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow Blkaclisting URLs from config #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76577e
Allow Blkaclisting URLs from config
zelima Jun 22, 2020
2dd12ad
Consider empty string for blacklist url
zelima Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions datapusher/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
'resource_update': '{ckan_url}/api/action/resource_update'
}

BLACKLIST = web.app.config.get('BLACKLIST_URLS', '').split(' ')

class HTTPError(util.JobError):
"""Exception that's raised if a job fails due to an HTTP problem."""
Expand Down Expand Up @@ -351,6 +352,12 @@ def push_to_datastore(task_id, input, dry_run=False):
raise util.JobError(
'Only http, https, and ftp resources may be fetched.'
)

for black_url in BLACKLIST:
if black_url and black_url in url:
raise util.JobError(
'Resouce can not be fetched - Given URL is blacklisted: %s' % url
)

# fetch the resource data
logger.info('Fetching from: {0}'.format(url))
Expand Down