add simple Dockerfile #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the current state of ckan core's contrib/docker, and the existing PRs a non-controversial and useful next-step would be to add a basic Dockerfile to this repo. Any additional work in the other PRs can be done on top of this. Current state of DataPusher: ckan core's Docker contrib uses a 3rd party repo that has a basic Dockerfile https://github.com/ckan/ckan/blob/master/contrib/docker/docker-compose.yml#L44 https://github.com/clementmouchet/datapusher/blob/master/Dockerfile To stop using that 3rd party repo we only need this Dockerfile. There exists a PR for adding this Dockerfile, and a docker-compose.yml. The Dockerfile is required for Docker contrib's docker-compose.yml to work. ckan#136 The docker-compose.yml may be required for when a user wants to break the datapusher out on to another machine, but they could also just copy the relevant section from ckan core or use the example from the other PR. There exists another PR for running Datapusher behind it's own version of Apache, this is super useful, but is a very specific architecture choice. I'm glad the PR is there, but it may be too specific to add to the plugin repo as the default. ckan#110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amercader Hopefully this is useful :)
Given the current state of ckan core's contrib/docker, and the existing PRs
a non-controversial and useful next-step would be to add a basic Dockerfile to this repo.
Any additional work in the other PRs can be done on top of this.
Current state of DataPusher:
ckan core's Docker contrib uses a 3rd party repo that has a basic
Dockerfile
https://github.com/ckan/ckan/blob/master/contrib/docker/docker-compose.yml#L44
https://github.com/clementmouchet/datapusher/blob/master/Dockerfile
To stop using that 3rd party repo we only need this Dockerfile and a PR against ckan-core to update it that I'm happy to open.
There exists a PR for adding this Dockerfile, and a docker-compose.yml.
The Dockerfile is required for Docker contrib's docker-compose.yml to
work.
#136
The docker-compose.yml may be required for when a user wants to
break the datapusher out on to another machine, but they could also
just copy the relevant section from ckan core or use the example
from the other PR.
There exists another PR for running Datapusher behind it's own version
of Apache, this is super useful, but is a very specific architecture choice.
I'm glad the PR is there, but it may be too specific to add to the plugin repo as the default.
#110