Skip to content

Site-wide validation overrides#89

Open
wardi wants to merge 2 commits intockan:masterfrom
open-data:override-validation
Open

Site-wide validation overrides#89
wardi wants to merge 2 commits intockan:masterfrom
open-data:override-validation

Conversation

@wardi
Copy link

@wardi wardi commented Jul 17, 2023

We use this to implement a "UTF-8-only" policy, but the same could be used for standardizing other options across a site with a configuration option.

Copy link
Contributor

@ThrawnCA ThrawnCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is broken.

@wardi
Copy link
Author

wardi commented Jul 19, 2023

failure is unrelated to this change.

The problem is our tests are creating a resource with ckan's factory, which creates a dataset, then passes the resource to a new dataset factory, but that resource already belongs to a dataset.

@ThrawnCA
Copy link
Contributor

It may be unrelated, but it still means this change isn't properly tested.

How easily can the tests be fixed?

@JVickery-TBS JVickery-TBS deleted the override-validation branch January 9, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants