Don't process extra resources on resource_create#74
Draft
Conversation
In async mode, if a dataset already has one or more resources suitable for validation, when adding a new one all the previous ones are also sent to validate. @ThrawnCA patch in #67, dealt with the same scenario but when updating an existing resource. In this case sadly we need to use the context, as there is no way to reliably tell in `after_update` if it's part of a resource_create call
ThrawnCA
reviewed
Oct 27, 2022
| if is_dataset: | ||
| return self._process_schema_fields(data_dict) | ||
| else: | ||
| context["_resource_create_call"] = True |
Contributor
There was a problem hiding this comment.
CKAN 2.10 will restrict the allowed context keys...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In async mode, if a dataset already has one or more resources suitable for validation, when adding a new one all the previous ones are also sent to validate.
@ThrawnCA patch in #67, dealt with the same scenario but when updating an existing resource.
In this case sadly we need to use the context, as there is no way to reliably tell in
after_updateif it's part of a resource_create call