Fix new issue tmpl

ckanext/issues/controller/controller.py

@@ -103,7 +103,7 @@ def new(self, dataset_id, resource_id=None):
                 })
 
             if not data_dict['title']:
-                c.error_summary['title'] = ["Please enter a title"]
+                c.error_summary[_('title')] = [_("Please enter a title")]
             c.errors = c.error_summary
 
             if not c.error_summary:  # save and redirect
@@ -128,10 +128,10 @@ def show(self, issue_number, dataset_id):
                                    session=model.Session)
         except toolkit.ValidationError, e:
             p.toolkit.abort(
-                404, toolkit._('Issue not found: {0}'.format(e.error_summary)))
+                404, toolkit._(u'Issue not found: {0}').format(e.error_summary))
         except toolkit.ObjectNotFound, e:
             p.toolkit.abort(
-                404, toolkit._('Issue not found: {0}'.format(e)))
+                404, toolkit._(u'Issue not found: {0}').format(e))
         extra_vars['dataset'] = dataset
         return p.toolkit.render('issues/show.html', extra_vars=extra_vars)
 
@@ -210,7 +210,10 @@ def comments(self, dataset_id, issue_number):
                 'dataset_id': dataset['id'],
                 'status': status
                 }
-            logic.get_action('issue_update')(self.context, issue_dict)
+            try:
+                logic.get_action('issue_update')(self.context, issue_dict)
+            except p.toolkit.NotAuthorized as e:
+                p.toolkit.abort(401, e.message)
             if 'close' in request.POST:
                 h.flash_success(_("Issue closed"))
             else:
@@ -252,13 +255,11 @@ def delete(self, dataset_id, issue_number):
                                'dataset_id': dataset_id}
                 )
             except toolkit.NotAuthorized:
-                msg = _('Unauthorized to delete issue {0}'.format(
-                    issue_number))
+                msg = _(u'Unauthorized to delete issue {0}').format(
+                    issue_number)
                 toolkit.abort(401, msg)
 
-            h.flash_notice(
-                _('Issue {0} has been deleted.'.format(issue_number))
-            )
+            h.flash_notice(_(u'Issue has been deleted.'))
             p.toolkit.redirect_to('issues_dataset', dataset_id=dataset_id)
         else:
             return render('issues/confirm_delete.html',
@@ -275,7 +276,7 @@ def assign(self, dataset_id, issue_number):
                 assignee = toolkit.get_action('user_show')(
                     data_dict={'id': assignee_id})
             except toolkit.ObjectNotFound:
-                h.flash_error(_('User {0} does not exist'.format(assignee_id)))
+                h.flash_error(_(u'User {0} does not exist').format(assignee_id))
                 return p.toolkit.redirect_to('issues_show',
                                              issue_number=issue_number,
                                              dataset_id=dataset_id)
@@ -295,8 +296,8 @@ def assign(self, dataset_id, issue_number):
 
                 if notifications:
                     subject = get_issue_subject(issue)
-                    body = toolkit._('Assigned to {user}'.format(
-                        user=assignee['display_name']))
+                    msg = toolkit._("Assigned to %s")
+                    body = msg % assignee['display_name']
 
                     user_obj = model.User.get(assignee_id)
                     try:
@@ -305,8 +306,7 @@ def assign(self, dataset_id, issue_number):
                         log.debug(e.message)
 
             except toolkit.NotAuthorized:
-                msg = _('Unauthorized to assign users to issue'.format(
-                    issue_number))
+                msg = _(u'Unauthorized to assign users to issue')
                 toolkit.abort(401, msg)
             except toolkit.ValidationError, e:
                 toolkit.abort(404)
@@ -404,9 +404,7 @@ def report_clear(self, dataset_id, issue_number):
                                       dataset_id=dataset_id,
                                       issue_number=issue_number)
             except toolkit.NotAuthorized:
-                msg = _('You must be logged in clear abuse reports').format(
-                    issue_number
-                )
+                msg = _(u'You must be logged in clear abuse reports')
                 toolkit.abort(401, msg)
             except toolkit.ValidationError:
                 toolkit.abort(404)
@@ -427,9 +425,7 @@ def comment_report_clear(self, dataset_id, issue_number, comment_id):
                                       dataset_id=dataset_id,
                                       issue_number=issue_number)
             except toolkit.NotAuthorized:
-                msg = _('You must be logged in to clear abuse reports').format(
-                    issue_number
-                )
+                msg = _(u'You must be logged in to clear abuse reports')
                 toolkit.abort(401, msg)
             except toolkit.ValidationError:
                 toolkit.abort(404)
@@ -444,8 +440,8 @@ def issues_for_organization(self, org_id):
         try:
             template_params = issues_for_org(org_id, request.GET)
         except toolkit.ValidationError, e:
-            msg = toolkit._("Validation error: {0}".format(e.error_summary))
-            log.warning(msg + ' - Issues for org: %s', org_id)
+            msg = toolkit._(u'Validation error: {0}').format(e.error_summary)
+            log.warning(msg + u' - Issues for org: %s', org_id)
             h.flash(msg, category='alert-error')
             return p.toolkit.redirect_to('issues_for_organization',
                                          org_id=org_id)
@@ -484,7 +480,7 @@ def all_issues_page(self):
 
 
 def _dataset_handle_error(dataset_id, exc):
-    msg = toolkit._("Validation error: {0}".format(exc.error_summary))
+    msg = toolkit._(u'Validation error: {0}').format(exc.error_summary)
     h.flash(msg, category='alert-error')
     return p.toolkit.redirect_to('issues_dataset', dataset_id=dataset_id)