Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1:
the bug description and solution was mistaken in this Pull request, please check newer pull request:
Fixed few bugs #3
Bug 2:
on integrity.h,
IMAGE_SCN_MEM_EXECUTEis a macro that is predefined in ntimage.h, if that header is imported somewhere else in project.attempting to declare and initialize a constant with same name will make variable name expand to a constant value after preprocessing.
**Fix: ** i have wrapped it in an
#ifndef IMAGE_SCN_MEM_EXECUTEblock