feat: Create context menu framework for goals when within the room context#153
Open
feat: Create context menu framework for goals when within the room context#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a context menu to goals which is brought up when the gal is right clicked within a room. This is a prerequisite for more complex interactions that either can't or shouldn't be bound to a mouse or keyboard interaction, as well as giving alternative mechanisms for accessing functionality on devices where full keyboard and/or mouse functionality may not be available (i.e. tablets).
This context menu should serve as a host for all potential non-primary goal actions added in the future, but should not necessarily be the only method of accessing the action - this should be determined on a case by case basis for each action.
This feature changes current room functionality. This change removes the current ability to star gals by right clicking them, as right clicking will now brink up the context menu. The star action has been moved to Ctrl+RMB. Additionally, incrementing/decrementing goal progress has been additionally mapped to Ctrl+LMB and Ctrl_Shift+LMB, respectively (this is an addition, no existing functionality on progress tracking is changed)