Skip to content

Conversation

@lkundrak
Copy link

@lkundrak lkundrak commented Jun 7, 2014

This makes it possible to support character sets where glyphs cross
byte boundaries. Defaults to UTF-8.

This makes it possible to support character sets where glyphs cross
byte boundaries. Defaults to UTF-8.
@lkundrak
Copy link
Author

lkundrak commented Jun 7, 2014

Oh, now I see that there's some utf8 support already -- I started off an old version.

It seems unnecessary complicated and... weird. Leaving this open just in case you'd like to replace that one. Otherwise please just close this.

Thank you.

@cjones
Copy link
Owner

cjones commented Jul 5, 2014

Sorry for the late response. Go right ahead, I didn't add the utf-8 support in the first place so I'm not particularly attached to it. I didn't look very hard at the code before accepting the pull request, perl makes me cranky, so I'm not surprised. The only thing I ask is it doesn't require a third party/CPAN module dependency, or degrades quietly/gracefully in the absence of such.

@cjones
Copy link
Owner

cjones commented Jul 5, 2014

Er, yeah, I see now that you already have the commit here, which looks fine, but I don't see the code being removed that you mentioned. Will the two conflict at all?

(By "didn't look very hard" I mean I glanced briefly to make sure it wasn't blatantly malicious, but I don't remember what got changed.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants