Skip to content
This repository was archived by the owner on Nov 24, 2017. It is now read-only.

Conversation

@ce-manalang
Copy link

Followed advice from http://stackoverflow.com/a/8873922

@cjohansen
Copy link
Owner

So this basically ignores invalid utf-8 characters? Wouldn't it be better to fix them in the source files?

@ce-manalang
Copy link
Author

@cjohansen yes we can fix the source files but if we want to juice a lot of js files with too many invalid chars, we have to go through them one by one.

Is it a good compromise if we just add a warning while juicing a file with invalid chars that those chars will be ignored? That way, juicing problematic files won't error out but it will not just silently juice.

Thoughts?

@cjohansen
Copy link
Owner

Warnings are a good compromise :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants