Consistent memory allocation and memory leak prevention #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
This patch aims to prevent memory leaks in the situation of out of memory.
It is done by eliminating alloc/free pairs with single CBuffer object, which deletes corresponding memory automatically in destructor (RAII).
So now throwing of std::bad_alloc (or any other exception in new) is safe, all memory will be freed.
Also all malloc/free operators substituted with new/delete (It is not recommended to mix them in the same program).
Comparing to Pull Request #4, this variant does not use std::vector (it can be inconvenient in some cases) and this patch changes all memory allocations in one time.
Codestyle is subject to discuss, so I can change it (or you can do it easily by yourself).