Ensure endless rules are on a single line#56
Open
eric1234 wants to merge 1 commit intocjheath:masterfrom
Open
Conversation
In 7df506e I had added an endless rule but I made a mistake in the semantic predicate. I examined the first token (aka `'rule'`) and not the last one (the "parsing expression"). @cjhealth fixed it up for me in 229d2c8 but it seems prudent to add a test to verify this. This commit adds this test. If I update the test replacing the newline with just a normal space between the literals then test fails. But with the newline in the parsing expression the test passes (i.e. it fails to parse).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7df506e I had added an endless rule but I made a mistake in the semantic predicate. I examined the first token (aka
'rule') and not the last one (the "parsing expression").@cjhealth fixed it up for me in 229d2c8 but it seems prudent to add a test to verify this.
This commit adds this test. If I update the test replacing the newline with just a normal space between the literals then test fails. But with the newline in the parsing expression the test passes (i.e. it fails to parse).