Tidy up documentation #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your Strand is being resumed externally, eg by receiving events from an event machine connection, it is possible that these resumes will occur while Strand is yielded in #pass or #sleep This change adds Strand#safe_yield that queues the resumes until we find the one we want. Strand#yield is changed to immediately return any previously queued resumes before calling Fiber#yield.
ensure that Strand::ConditionVariable only wakes up to the signal or timeout and not to an out of order resume also store the requeued resumes in instance variable on Strand class instead of in Strand local storage, so that condition variables can be waited from non Strand Fibers
Resynchronised with upstream
Specs for alive, local storage, pass, sleep Strand.sleep allow nil to mean sleep forever (rather than error) Raise TypeErrors for local storage that cannot be converted to symbols
Remove jeweler in favour of bundler's integrated rake tasks Put gem configuration in strand.gemspec, remove Gemfile.lock this seems to be recommended way to deal with development (as distinct from use) of library type gems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for taking the previous pull. This one makes the documentation a bit more consistent for the new approach.
I'm happy with being credited via the git history but equally happy to be listed as an author if you want. I'll leave it up to you - details as per my github profile.
PS. If you want to prerelease to rubygems apparently just needs the version to have an alpha character in it.
http://guides.rubygems.org/patterns/#prerelease-gems