Saving name and description about a popit api instance#861
Saving name and description about a popit api instance#861
Conversation
|
|
…d using a class level attribute to refer to the about_class
chrismytton
force-pushed
the
issues/846/chicken-way
branch
from
2b09ff9 to
6f19ddc
Compare
|
|
1 similar comment
…d using a class level attribute to refer to the about_class
|
|
|
Changes Unknown when pulling 2b11068 on issues/846/chicken-way into * on master*. |
1 similar comment
|
Changes Unknown when pulling 2b11068 on issues/846/chicken-way into * on master*. |
…tance.py that was still there for some reason
|
|
|
Changes Unknown when pulling 3d97456 on issues/846/chicken-way into * on master*. |
1 similar comment
|
Changes Unknown when pulling 3d97456 on issues/846/chicken-way into * on master*. |
3 participants
This PR adds a method to all the PopitApiInstances out there so they can get information about what their name is and description, this PR will also store that information.
Unfortunately, the url cannot yet be determined correctly so you might be tempted to not accept this PR until we have that sorted out, the explanation for that problem can be found in get_about().
This also provides vcrpy to the tests which could probably help to solve #600.
This does not get the
about your popitinformation when loading from popit.So probably in order to finish #846 we would need to:
about your popitinfo when pulling from popit.Please don't merge just yet I think it still needs some work.