Conversation
This should fix the warnings of the form: "Model class social.apps.django_app.default.models.[some class] doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9."
1 similar comment
1 similar comment
dracos
approved these changes
Feb 9, 2017
Collaborator
dracos
left a comment
dracos
left a comment
There was a problem hiding this comment.
All looks good, one qn :)
| 'pyelasticsearch', | ||
| 'celery', | ||
| 'pyyaml', | ||
| 'django-celery', |
Collaborator
There was a problem hiding this comment.
If it's still in requirements/settings, should it not be here too?
Collaborator
Author
There was a problem hiding this comment.
Oh yes, good point! (That's because at first I took out django-celery completely, and then realised it would be helpful to still have for the results backend...)
We switch to using Celery in the manner recommended in Celery 3.1 and later. We wouldn't need django-celery any more, except that we're using it provides a Django ORM-based results backend for Celery. We upgrade django-celery to avoid some deprecation warnings. The celery worker and beat are no longer invoked using manage.py but with the celery script.
This test was failing because of this error: ValueError: assertTemplateUsed() and assertTemplateNotUsed() are only usable on responses fetched using the Django test Client. However, I'm a bit unclear on how this ever worked, since the template parameter for WriteItDeleteView was never being overridden?
These tests are now erroring with the stricter argument parsing in Django 1.8. I can't see that this arguement was ever used for anything anyway.
It looks as if django.core.mail.mail_admins now uses django.core.mail.EmailMultiAlternatives.send whereas it didn't in earlier versions of Django. mail_admins is used in the handling of an exception, so we need to patch that to stop our test exception being raised in the exception handling as well.
"pip check" picked up that Celery 3.1.25 requires upgraded versions of these packages.
The version in use had security issue: CVE-2016-9243
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that this works now - this pull request it targets the
migrate-to-django-popolobranch, which hopefully can be merged soon after some testing from clients of the API.