Migration to django-popolo part 3#1196
Merged
mhl merged 33 commits intoreviewed-migrate-to-django-popolofrom Oct 6, 2016
Merged
Migration to django-popolo part 3#1196mhl merged 33 commits intoreviewed-migrate-to-django-popolofrom
mhl merged 33 commits intoreviewed-migrate-to-django-popolofrom
Conversation
This also involves renaming the celery tasks and many methods that referred to PopIt explicitly so that they no longer do.
This depends on this commit: everypolitician/everypolitician-writeinpublic@ae62cad ... which has been deployed now.
This include a migration that changes some foreign keys to use the PopoloPerson proxy model instead of the base Person model.
Rather than using the /persons collection endpoint of PopIt's API, the code now just uses export.json to extract Popolo JSON from PopIt. This commit has the results of re-recording these fixtures (using roughly the procedure here: https://gist.github.com/mhl/848f7980d256ca38ff603375be4f264e ). The exception was persons_with_null_values.yaml which seems to be missing the source JSON MongoDB fixture, so this was created by hand based on one of the others.
The start_local_popit_api.bash script is designed to make it easy to set up a local version of PopIt for testing against; this is still useful for re-recording the fixtures (see the commit message for 967f842529 and https://gist.github.com/mhl/848f7980d256ca38ff603375be4f264e ). However, this script installed a very old version of PopIt - this commit updates it to use the most recent version. (A key problem with the old version of this script is that it sets up a version of PopIt without the export.json endpoints.)
This doesn't seem to matter, and since there is no Identifier associated with a ContactDetail in django-popolo, it'd be awkward to preserve the ContactDetail identifiers. It doesn't seem to be actually used anyway.
mhl
force-pushed
the
migrate-to-django-popolo-part-3
branch
from
dc98bea to
0ecc77e
Compare
chrismytton
approved these changes
Sep 26, 2016
Contributor
chrismytton
left a comment
chrismytton
left a comment
There was a problem hiding this comment.
This is quite a big pull request!
I've had a look through the code changes and run the migration successfully on my local instance and it all appeared to work correctly. It's tricky to know whether I've tested exhaustively, but I've had a good click around and nothing was obviously broken :)
👍 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the third part of: #1181 for review. See that pull request for the context for this pull request.
This should update all the code and tests to use the new models with the migrated data, and update the new models from Popolo JSON sources.
I've tried to make sure that the API still works for clients with the same identifiers, but I find tastypie quite confusing, so it's definitely worth double-checking all of that.
Also particularly worth looking at is: "Update the code to sync from Popolo JSON, not a PopIt instance" f9fd9e9.