Display owner ENS name if one exists#105
Draft
ssdsr wants to merge 5 commits intocitydaoproject:mainfrom
Draft
Conversation
|
@ssdsr is attempting to deploy a commit to the CityDAO Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation
Passed the mainnet Provider down through props from Web3Wrapper and used useResolveEnsName hook from
eth-hooks.Current state
I haven't been able to get it to display an ENS name with that hook yet. Example: Plot #4748 does not display ENS name even though one exists
Worth noting
I've noticed that some amount of plots don't show up on opensea (https://opensea.io/assets/ethereum/0x90384e76b6b3ddb47396ff85144819ded148900d/7492)
Proxy for Opensea API
The opensea API request is now proxied with a serverless function via the implementation provided by @trkaplan: https://github.com/trkaplan/opensea-api-proxy
Before
After