-
Notifications
You must be signed in to change notification settings - Fork 7
Implement ccip016 #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
=======================================
Coverage 88.47% 88.47%
=======================================
Files 26 26
Lines 1831 1831
Branches 316 316
=======================================
Hits 1620 1620
Misses 183 183
Partials 28 28 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
whoabuddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! 🙏 Left some feedback on what I saw in the review comments.
I would like to add some testing around the contract alongside the simulation, mostly to make sure the voting works as expected. Payout code looks clean/simple but will be important to make sure we can reproduce those numbers from the CCIP text/resources.
| (define-constant CCIP_016 { | ||
| name: "Refund Incorrect CCD007 Payouts", | ||
| link: "https://github.com/citycoins/governance/blob/feat/add-ccip-016/ccips/ccip-016/ccip-016-refund-incorrect-ccd007-payouts.md", | ||
| hash: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that the CCIP-016 governance text needs to be updated and hash can be added here.
We're on version 3 for clarinet, probably failing check because of new epoch definition.
This PR