Skip to content

Conversation

@friedger
Copy link
Contributor

@friedger friedger commented Dec 4, 2024

This PR

  • adds a proposal that distributes missed payouts for mia stakers as defined in CCIP-016

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.47%. Comparing base (628a387) to head (badda12).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   88.47%   88.47%           
=======================================
  Files          26       26           
  Lines        1831     1831           
  Branches      316      316           
=======================================
  Hits         1620     1620           
  Misses        183      183           
  Partials       28       28           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 628a387...badda12. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@whoabuddy whoabuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! 🙏 Left some feedback on what I saw in the review comments.

I would like to add some testing around the contract alongside the simulation, mostly to make sure the voting works as expected. Payout code looks clean/simple but will be important to make sure we can reproduce those numbers from the CCIP text/resources.

(define-constant CCIP_016 {
name: "Refund Incorrect CCD007 Payouts",
link: "https://github.com/citycoins/governance/blob/feat/add-ccip-016/ccips/ccip-016/ccip-016-refund-incorrect-ccd007-payouts.md",
hash: "",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that the CCIP-016 governance text needs to be updated and hash can be added here.

@friedger friedger requested a review from whoabuddy April 15, 2025 12:08
@friedger
Copy link
Contributor Author

friedger and others added 3 commits June 3, 2025 19:01
We're on version 3 for clarinet, probably failing check because of new epoch definition.
@whoabuddy whoabuddy merged commit 1f72c8d into main Sep 4, 2025
2 checks passed
@whoabuddy whoabuddy deleted the fix/implement-ccip-016 branch September 4, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants