Skip to content

Conversation

@Gogsi
Copy link
Contributor

@Gogsi Gogsi commented Aug 26, 2025

Goal of this PR

Somehow, users are ending up with an invalid JSON in the PoolSizesIncrease field in CitizenFX.ini. This PR catches the parse_error exception and resets PoolSizesIncrease to an empty value.

How is this PR achieving the goal

Catching the nlohmann::json_abi_v3_11_2::detail::parse_error exception, leaving the sizeIncrease map empty and emptying the PoolSizesIncrease field

This PR applies to the following area(s)

FiveM, RedM

Successfully tested on

Game builds: 3095, 3258

Platforms: Windows

Notes: Only tested on top of #3585 because I can't compile the client otherwise. I cherry-picked my commit and submitted only it

Checklist

  • [ x] Code compiles and has been tested successfully.
  • [x ] Code explains itself well and/or is documented.
  • [x ] My commit message explains what the changes do and what they are for.
  • [x ] No extra compilation warnings are added by these changes.

Fixes issues

Fixes this issue reported a few times on Discord https://discord.com/channels/192358910387159041/1409630888777613332/1409630888777613332

image

@github-actions github-actions bot added RedM Issues/PRs related to RedM invalid Requires changes before it's considered valid and can be (re)triaged labels Aug 26, 2025
@Gogsi
Copy link
Contributor Author

Gogsi commented Aug 28, 2025

Encountered the issue again in the Cfx Discord. This time I asked to see their CitizenFX.ini. Not sure how, but a part of the json was missing.

image

@lonebadgerCfx
Copy link

It appears that poolSize could be fixed with this update. Please pull it innnn

@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Nov 24, 2025
@prikolium-cfx prikolium-cfx merged commit 4123c9d into citizenfx:master Nov 25, 2025
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is enqueued for merging RedM Issues/PRs related to RedM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants