Skip to content

Conversation

@stark-3k
Copy link

@stark-3k stark-3k commented Jan 4, 2026

No description provided.

@mojoX911
Copy link

mojoX911 commented Jan 4, 2026

Is the same logic available for V1 api too?

@mojoX911
Copy link

mojoX911 commented Jan 4, 2026

Also can we add the logic here to clear incoming swapcoins that are expired ,yet the other party didn't claim it? Currently, they are dangling, and there's no way to clear them from the contract balance.

@stark-3k
Copy link
Author

stark-3k commented Jan 4, 2026

Is the same logic available for V1 api too?

yes v1 has a recovery loop

Also can we add the logic here to clear incoming swapcoins that are expired ,yet the other party didn't claim it? Currently, they are dangling, and there's no way to clear them from the contract balance.

Added the logic for maker to remove orphaned incoming swapcoins

Copy link

@mojoX911 mojoX911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. Tested that dangling swapcoins are removed.

@codecov
Copy link

codecov bot commented Jan 4, 2026

Codecov Report

❌ Patch coverage is 67.60563% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.14%. Comparing base (776b75d) to head (6ad1ef5).
⚠️ Report is 80 commits behind head on master.

Files with missing lines Patch % Lines
src/taker/api2.rs 73.84% 17 Missing ⚠️
src/maker/api2.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   68.87%   78.14%   +9.27%     
==========================================
  Files          35       49      +14     
  Lines        4932    15239   +10307     
==========================================
+ Hits         3397    11909    +8512     
- Misses       1535     3330    +1795     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojoX911 mojoX911 merged commit 1b62466 into citadel-tech:master Jan 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants