Merged
Conversation
williewillus
commented
Mar 7, 2026
williewillus
commented
Mar 7, 2026
williewillus
force-pushed
the
named-cc
branch
2 times, most recently
from
fde36ae to
547e97b
Compare
jltaylor-us
requested changes
Mar 8, 2026
Contributor
jltaylor-us
left a comment
jltaylor-us
left a comment
There was a problem hiding this comment.
I'm not sure what problem this is solving that couldn't be handled pretty simply by just creating and storing/passing around (name . cc) pairs instead, but I don't think it will hurt anything... and there is already precedent for something similar with make-mutex.
Contributor
Author
|
Addressed comments |
jltaylor-us
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. It's nice to have when you're juggling lots of them at once without having to track the names of each one in "external" maps.
Updated tests and also tested locally on REPL.