Open
Conversation
# Conflicts: # train-tracker/src/TrainMap.js
nicholasrehac
requested review from
ahgoldmeer,
ldups,
molly-pop,
tjmcb and
wSimsT
tjmcb
approved these changes
Nov 30, 2024
tjmcb
left a comment
tjmcb
left a comment
There was a problem hiding this comment.
I can look at these all day, great stuff, good luck merging with all the changes we've made since lol
ahgoldmeer
reviewed
Dec 1, 2024
ahgoldmeer
left a comment
ahgoldmeer
left a comment
There was a problem hiding this comment.
This...apparently doesn't create merge conflicts. I know this is technically able to be merged with three approvals but PLEASE merge main into this branch and test it before potentially merging this into main.
Really cool work though. Well done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Places markers on the track where they are expected to be after having traveled at their last reported speed.