Add extra open/close states for the switches#322
Open
DeeHants wants to merge 7 commits intocircuitdiagram:masterfrom
Open
Add extra open/close states for the switches#322DeeHants wants to merge 7 commits intocircuitdiagram:masterfrom
DeeHants wants to merge 7 commits intocircuitdiagram:masterfrom
Conversation
DeeHants
commented
Nov 5, 2024
| <group conditions="!horizontal,!$Type==Changeover"> | ||
| <connection name="a" start="_Start" end="_Middle-16y" edge="Start" /> | ||
| <connection name="a" start="_Middle+16y" end="_End" edge="End" /> | ||
| <connection name="b" start="_Middle+16y" end="_End" edge="End" /> |
Contributor
Author
There was a problem hiding this comment.
I assume this was a typo so fixed it too
Contributor
Author
|
I think this is ready for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an open rendering for the "analogue", "changeover" and "push to break" switch, using the same 3px gap as the "push" switch.
$Type=PushToBreak, $Closed=false$Type=PushToBreak, $Closed=true$Type=Changeover, $Closed=false(connected to B, left/top)$Type=Changeover, $Closed=true(Connected to C, right/bottom)(I'm aware the vertical has changed the default orientation pole direction, but this matches the b/c of the horizontal.)
$Type=Analogue, $Closed=false$Type=Analogue, $Closed=true