Extend input declarations in Z# to support structs#218
Closed
lorenzorota wants to merge 0 commit intocircify:masterfrom
Closed
Extend input declarations in Z# to support structs#218lorenzorota wants to merge 0 commit intocircify:masterfrom
lorenzorota wants to merge 0 commit intocircify:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, program inputs cannot be declared for structs that are being returned. Take the following program
with the value maps
and
for the prover and verifier, respectively. This would throw a not implemented error since precomputations are not handled.
This PR adds the missing precomputations, similar to how it's done for arrays and mutable arrays, i.e., computing the precomputations by unwrapping all the struct fields. For this I included two new functions in
T:unwrap_structandunwrap_struct_ir, which both return a FieldList or an error.