Add support for ZoKrates with curly brackets (wip) by StefanosChaliasos · Pull Request #211 · circify/circ

StefanosChaliasos · 2024-10-30T13:09:39Z

This PR tries to address #208.
Some of the features that are not supported by the grammar are:

Integer
cond_store
Array Metadata
Witness

Furthermore, we don't currently support MPC.

Finally, the implementation of assembly has not been tested and shouldn't be complete.

All the tests pass. To run them, you can use the following commands:

cargo build --release --features=r1cs --features=smt --features=zok --features=lp --features=bellman --features=zokc --example=circ
cargo build --release --features=r1cs --features=smt --features=zokc --features=lp  --features=bellman --example=zcxi
./scripts/zokrates_curly_test.zsh

The changes to support ZoKrates with curly brackets are the following:

We added third_party/ZoKratesCurly.
We added a new frontend, src/front/zsharpcurly.
We added a new feature called zokc.
We updated circ executable to support zsharpcurly and implemented zcxi.
Finally, we copied and updated the tests and the scripts to run the tests for zsharpcurly.

TODOs:

Check that all tests have been converted correctly (which are not!)
Fix assembly
Apply the proper format
Do we want to support MPC?

Note that you can check the changes vs the original implementation in the first 4 commits of this PR.

We jsut copy pasted the existing frontend and updated the configurations and scripts to support both Zokrates frontends

…urcly-based)

alex-ozdemir

This is a very nice patch, Stefanos. I have a few questions about it, but I think they should be easy to address.

src/front/zsharpcurly/interp.rs

src/front/zsharpcurly/mod.rs

Also adds missing tests for tuples

alex-ozdemir

This looks good to me now.
If you're happy with it, then I'll merge it.

StefanosChaliasos · 2024-12-13T12:55:31Z

src/front/zsharpcurly/mod.rs

+        }
+    }
+
+    fn assembly_assign_impl_<const IS_CNST: bool>(


@alex-ozdemir, can you review this code?

StefanosChaliasos · 2024-12-13T12:56:12Z

src/front/zsharpcurly/mod.rs

+        }
+    }
+
+    fn assembly_constraint_<const IS_CNST: bool>(


Here I just add the assembly constraints like it was an assertion.

StefanosChaliasos · 2024-12-13T12:59:25Z

I think that if we make sure that assembly is handled correctly, then we can proceed. ref: https://zokrates.github.io/language/assembly.html

alex-ozdemir · 2024-12-13T22:47:23Z

Is the omission of field_to_bool_unsafe intentional?

StefanosChaliasos · 2025-01-21T16:36:12Z

src/front/zsharpcurly/term.rs

+    }
+}
+
+pub fn field_to_bool_unsafe(f: T) -> Result<T, String> {


@alex-ozdemir, can you review this one?

I think that you actually want this operator using it will maintain the connection between the input and the output of the operator in the final constraint system, it will just assume that the value is 0 or 1. See this part of R1CS lowering.

What do you think?

Thanks, that makes sense! Should we still wrap it in a new_witness Op? If we do so, in the test, should we also pass the new_witness value?

Thanks, that makes sense! Should we still wrap it in a new_witness Op?

No, you should not.

StefanosChaliasos · 2025-01-21T16:37:10Z

Sorry for the delay. It was not intentional; I tried to implement it (without changing the IR), but the test failed.

alex-ozdemir

(A change may not be necessary---see my comment and let me know what you think.)

alex-ozdemir · 2025-01-21T17:41:49Z

src/front/zsharpcurly/term.rs

+    }
+}
+
+pub fn field_to_bool_unsafe(f: T) -> Result<T, String> {


I think that you actually want this operator using it will maintain the connection between the input and the output of the operator in the final constraint system, it will just assume that the value is 0 or 1. See this part of R1CS lowering.

What do you think?

StefanosChaliasos · 2025-01-23T13:48:07Z

@alex-ozdemir fixed the issues, now the mpc tests fail. Seems like we miss libcrypto:

Server error: ./third_party/bin/ABY/aby_interpreter: error while loading shared libraries: libcrypto.so.1.1: cannot open shared object file: No such file or directory

alex-ozdemir · 2025-02-10T22:03:50Z

Hi @StefanosChaliasos ,

We've dodged the issue with ABY's testing infrastructure. (#221)
You should be able to merge/rebase and proceed with this PR.

Including: removing ABY's testing from the CI since the test infrastructure is pinned to specific a specific Ubuntu version.

StefanosChaliasos · 2025-02-12T12:49:18Z

Great, thanks! I think it's ready to be merged

alex-ozdemir · 2025-02-12T17:07:34Z

Wonderful, it's great to have this in!

StefanosChaliasos added 7 commits October 30, 2024 13:33

Add boilerplate code for a new Zokrates frontend (curcly brackets)

26f3e65

We jsut copy pasted the existing frontend and updated the configurations and scripts to support both Zokrates frontends

Update the Zokrates standard library and pest to the newer version (c…

bb5f2c5

…urcly-based)

Update tests and examples for ZoKratesCurly

a13a18e

Implement the ZSharpCurlyFE

ce9ddbf

Apply fmt

95e58e3

Add zcxi in Cargo.toml

cdbc804

Fix linting errors

1121700

alex-ozdemir requested changes Nov 6, 2024

View reviewed changes

src/front/zsharpcurly/interp.rs Outdated Show resolved Hide resolved

src/front/zsharpcurly/mod.rs Show resolved Hide resolved

src/front/zsharpcurly/mod.rs Outdated Show resolved Hide resolved

src/front/zsharpcurly/mod.rs Outdated Show resolved Hide resolved

StefanosChaliasos added 5 commits November 7, 2024 10:38

Correctly implement tuple for zsharpcurly

33f0075

Also adds missing tests for tuples

Update error message for MPC support

11aba74

Apply fmt

3309a0d

Remove commented out code

b2c08da

Fix linting error

9981366

alex-ozdemir approved these changes Dec 13, 2024

View reviewed changes

StefanosChaliasos added 2 commits December 13, 2024 14:00

Fix script for processing zcx tests

36497e1

Handle assembly assignments and constraints

79e1d94

StefanosChaliasos commented Dec 13, 2024

View reviewed changes

Remove deprecated comment

788fb51

StefanosChaliasos added 2 commits December 13, 2024 19:42

Add support for AssignConstrain (<==)

7f284b6

Remove print stmts

2629341

StefanosChaliasos added 2 commits January 21, 2025 18:29

Add support for field_to_bool_unsafe

3a32dcb

Uncomment tests and fmt changes

f442e2b

StefanosChaliasos commented Jan 21, 2025

View reviewed changes

alex-ozdemir requested changes Jan 21, 2025

View reviewed changes

StefanosChaliasos added 2 commits January 23, 2025 09:01

Fix field_to_bool_unsafe and some linting errors

8ece447

Fix type alias issue in type checking

94db4be

StefanosChaliasos added 4 commits January 23, 2025 09:18

Apply fmt

2704df6

Fix linting errors

51b8bf2

Fix linting errors

d4a1644

fmt changes

354d0fe

alex-ozdemir and others added 3 commits February 12, 2025 14:28

README: rm circom, add pointer to old implementation

78499d9

Fix the build (circify#221)

7836f55

Including: removing ABY's testing from the CI since the test infrastructure is pinned to specific a specific Ubuntu version.

Extend input declarations in Z# to support structs (circify#219)

0ffdcb5

alex-ozdemir merged commit 56c07d4 into circify:master Feb 12, 2025
1 check passed

Conversation

StefanosChaliasos commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alex-ozdemir left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alex-ozdemir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanosChaliasos commented Dec 13, 2024

Uh oh!

alex-ozdemir commented Dec 13, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanosChaliasos commented Jan 21, 2025

Uh oh!

alex-ozdemir left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StefanosChaliasos commented Jan 23, 2025

Uh oh!

alex-ozdemir commented Feb 10, 2025

Uh oh!

StefanosChaliasos commented Feb 12, 2025

Uh oh!

Uh oh!

alex-ozdemir commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StefanosChaliasos commented Oct 30, 2024 •

edited

Loading