Skip to content

Conversation

@sabinala
Copy link
Contributor

Removing the requirement that the string "nan" be included in the underflow error message. This error can also have the message "underflow in dt 0.0" or "underflow in dt {}" (per Tom's message on Slack).

Removing the requirement that the string "nan" be included in the underflow error message
@sabinala sabinala requested a review from SamWitty February 19, 2025 17:25
@sabinala sabinala added the awaiting review PR submitter awaiting code review from reviewer label Feb 19, 2025
@sabinala sabinala self-assigned this Feb 19, 2025
Copy link
Contributor

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SamWitty SamWitty merged commit e3d7d22 into main Feb 20, 2025
7 checks passed
@SamWitty SamWitty deleted the sabinala-patch-1 branch February 20, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review PR submitter awaiting code review from reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants