-
Notifications
You must be signed in to change notification settings - Fork 9
adding error messages and check for NaN values to compiled_dynamics #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The changes to Normally, I would write a unit test for this, but https://github.com/DARPA-ASKEM/simulation-integration has been archived, so I can no longer add models to this repo! @SamWitty let me know what you think, either we can merge the PR without a test, or I can add the test and add the offending model to another location and then to |
|
Also, I do not know why linting is failing! I ran I have not touched |
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
SamWitty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Adds a descriptive error message when an
underflowerror is thrown by an adaptive step size solver, or infinite/NaN values are returned for states and/or observables.See #643.