Remove waterlogged special cases #1856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leMaik
force-pushed
the
better-waterlogged
branch
2 times, most recently
from
1012da9 to
e10c803
Compare
leMaik
force-pushed
the
better-waterlogged
branch
from
e10c803 to
27ac4ab
Compare
leMaik
force-pushed
the
better-waterlogged
branch
from
27ac4ab to
6b4ddda
Compare
leMaik
force-pushed
the
better-waterlogged
branch
from
6b4ddda to
f95dd83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1692 in a (hopefully) slightly more elegant way.
We could even moveDone and it doesn't break anything. 🎉waterloggedandisWaterlogged()intoBlockwhere it would belong, but unfortunately the octree returnsMaterialfor blocks and changing that in 2.5.0 would break the octree plugin.