Merged
Conversation
chud0
requested changes
Sep 30, 2025
fast_cache_middleware/controller.py
Outdated
| import re | ||
| from hashlib import blake2b | ||
| from typing import Optional | ||
| from inspect import iscoroutinefunction |
Owner
There was a problem hiding this comment.
там же в старлетт есть is_async_callable оно в приватном _utils, но можно дернуть из использующего модуля, типа from starlette.routing import is_async_callable это хак, надежнее форкнуть метод себе с указанием откуда взяли
fast_cache_middleware/depends.py
Outdated
| from fastapi import params | ||
| from starlette.requests import Request | ||
|
|
||
| KeyFunc = Union[ |
Owner
There was a problem hiding this comment.
лучше так и назови SyncOrAsync если что потом переиспользовать можно будет, что то с названием типа KeyFunc врядли
fast_cache_middleware/schemas.py
Outdated
| description="Cache lifetime in seconds. If None, caching is disabled.", | ||
| ) | ||
| key_func: Callable[[Request], str] | None = Field( | ||
| key_func: Callable[[Request], str] | Callable[ |
Nottezz
force-pushed
the
asynchronous-cache-key-generation
branch
from
dc2dccd to
ede846e
Compare
chud0
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #20