Skip to content

Fix Redis type #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nottezz merged 3 commits into from
Sep 23, 2025
Merged

Fix Redis type #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
198339a
update redis version
Nottezz Sep 12, 2025
e6606cd
add redis to dev dep
Nottezz Sep 12, 2025
9515c15
fix redis type
Nottezz Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions fast_cache_middleware/storages/redis_storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
from typing import Optional, Union

try:
from redis.asyncio import Redis
import redis.asyncio as redis
except ImportError:
Redis = None # type: ignore
redis = None # type: ignore

from starlette.requests import Request
from starlette.responses import Response
Expand All @@ -26,11 +26,17 @@
class RedisStorage(BaseStorage):
def __init__(
self,
redis_client: Redis,
redis_client: redis.Redis,
serializer: Optional[BaseSerializer] = None,
ttl: Optional[Union[int, float]] = None,
namespace: str = "cache",
) -> None:
if redis is None:
raise ImportError(
"Redis is required for RedisStorage. "
"Install with Redis: fast-cache-middleware[redis]"
)

super().__init__(serializer, ttl)
self._serializer = serializer or JSONSerializer()

Expand Down
19 changes: 9 additions & 10 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ license = "MIT"
python = "^3.11"
fastapi = ">=0.111.1,<1.0.0"
pydantic = ">=1.7.4,<1.8 || >1.8,<1.8.1 || >1.8.1,<2.0.0 || >2.0.0,<2.0.1 || >2.0.1,<2.1.0 || >2.1.0,<3.0.0"
redis = { version = "^6.2.0", optional = true }
redis = { version = "^6.4.0", optional = true }

[tool.poetry.extras]
redis = ["redis"]
Expand All @@ -27,6 +27,7 @@ pytest-cov = "^4.1.0"
httpx = "^0.28.1"
uvicorn = "^0.34.3"
types-redis = "^4.6.0.20241004"
redis = "^6.4.0"


[tool.poetry.group.docs.dependencies]
Expand Down