Merged
Conversation
chud0
requested changes
Aug 25, 2025
chud0
approved these changes
Sep 4, 2025
Owner
chud0
left a comment
chud0
left a comment
There was a problem hiding this comment.
в целом получилось очень круто! хочешь в этом pr поменяй поведение метода, хочешь просто минорные изменения сделай следом после коммита
ну и нужно будет пересобрать и залить либу
|
|
||
| return cache_config, cache_drop_config | ||
|
|
||
| def _convert_methods_to_path( |
Owner
There was a problem hiding this comment.
это самописный метод? или выдрал из фастапи/старлета?
Collaborator
Author
There was a problem hiding this comment.
Самописный с использованием встроенных методов из старлета: compile_path, get_name
fast_cache_middleware/middleware.py
Outdated
| continue | ||
| seen.add(key) | ||
|
|
||
| cache_drop_config.paths.append(regex) |
Owner
There was a problem hiding this comment.
по хорошему кеш конфига здесь не должно быть, здесь только конверт метода, одного или списка, а где то выше, результат этого конверта подкидывается в конфиг
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #15