Now checks sub-LVLN as if they are already patched#1
Open
FrederikRasmussen wants to merge 1 commit intochuckseven1:masterfrom
Open
Now checks sub-LVLN as if they are already patched#1FrederikRasmussen wants to merge 1 commit intochuckseven1:masterfrom
FrederikRasmussen wants to merge 1 commit intochuckseven1:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
The following changes creates a new lvlnGender function that attempts a "positive look-ahead" where instead of assigning, Male, Female, or Mixed, it instead assigns Male or Female, as if we deleted all instances of Male already (or Female, if the deFem setting is true).
This avoids the reported issue of levelled lists becoming empty, which was caused by levelled lists that consisted entirely of Mixed genders having all entries removed.
In addition to the above, we no longer attempt to fix a LVLN that will inevitably becomes all Male (or Female, if the deFem setting is true), though I haven't been able to test this, as I do not have any mods where this would occur, and the base game similarly does not have a test case.