Rev killer, Barrows updates #298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| Microbot.log("Drinking"); | ||
| if(Rs2GameObject.interact(rej, "Drink")){ | ||
| if(rej.click("Drink")){ |
There was a problem hiding this comment.
Doesn't this break if you're not executing it on the client thread?
|
|
||
| public void fightrev(revKillerConfig config){ | ||
| Rs2NpcModel Rev = (Rs2Npc.getNpc(config.selectedRev().getName())); | ||
| Rs2NpcModel Rev = Rs2Npc.getNpc(config.selectedRev().getName()); |
| if(!Rs2Dialogue.isInDialogue()){ | ||
| Microbot.log("At the cave, clicking."); | ||
| if(Rs2GameObject.interact(31555, "Enter")){ | ||
| if(Microbot.getRs2TileObjectCache().query().withId(31555).nearest().click("Enter")){ |
| if(revenentKnight() == null) return; | ||
|
|
||
| if(Rs2Npc.attack("Revenant knight")){ | ||
| if(Rs2Npc.interact(revenentKnight(), "Attack")){ |
|
|
||
| if(Rs2GroundItem.isItemBasedOnValueOnGround(500,10)){ | ||
| return; | ||
| if(goodLootOnGround()){ |
There was a problem hiding this comment.
Nit-picking, but please apply proper formatting: a space after if and after the closing )
| if(!super.isRunning()){ | ||
| break; | ||
| List<Rs2TileItemModel> itemsOnGround = Microbot.getRs2TileItemCache().query().where(it -> it.getWorldLocation().distanceTo(Rs2Player.getWorldLocation()) < 12 && !it.getName().contains("arrow") && it.getTotalGeValue() > 500).toList(); | ||
| List<Rs2TileItemModel> BlightedItemsOnGround = Microbot.getRs2TileItemCache().query().where(it -> it.getWorldLocation().distanceTo(Rs2Player.getWorldLocation()) < 12 |
There was a problem hiding this comment.
variable names should be camelCase
| break; | ||
| List<Rs2TileItemModel> itemsOnGround = Microbot.getRs2TileItemCache().query().where(it -> it.getWorldLocation().distanceTo(Rs2Player.getWorldLocation()) < 12 && !it.getName().contains("arrow") && it.getTotalGeValue() > 500).toList(); | ||
| List<Rs2TileItemModel> BlightedItemsOnGround = Microbot.getRs2TileItemCache().query().where(it -> it.getWorldLocation().distanceTo(Rs2Player.getWorldLocation()) < 12 | ||
| && (it.getName().toLowerCase().contains("blighted") |
There was a problem hiding this comment.
I would personally keep the strings in a static final Set/List and iterate over it
| sleepUntil(()-> !Rs2Player.isAnimating() && !Rs2Inventory.isFull(), 1500); | ||
| } | ||
| } | ||
| if(!Rs2Inventory.isFull()){ |
There was a problem hiding this comment.
An else would be more appropriate here instead of this if
| } | ||
| } | ||
| if(!Rs2Inventory.isFull()){ | ||
| if(Microbot.getRs2TileItemCache().query().withId(theItem.getId()).nearest() != null){ |
There was a problem hiding this comment.
Use injected version instead of static one.
| if(Rs2Player.isMoving()){ | ||
| sleepUntil(()-> !Rs2Player.isMoving(), Rs2Random.between(3000,6000)); | ||
| if(!Rs2Inventory.isFull()){ | ||
| if(Microbot.getRs2TileItemCache().query().withId(theItem.getId()).nearest() != null){ |
There was a problem hiding this comment.
Use injected version instead of static one.
chsami
added a commit
that referenced
this pull request
Jan 29, 2026
Rev killer, Barrows updates (#298) * fix(BarrowsScript): numerous bug fixes * fix(RevKillerScript): numerous bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numerous bug fixes