🛡️ Sentinel: [CRITICAL] Fix Graph & SQL query injection in AST & DB tools#273
Conversation
* Parameterized `queryCodeGraph` in AST helpers (`apps/api/lib/ast/storeFalkorGraph.ts`) to prevent Cypher injection on `functionName` and `moduleName`. * Parameterized SQL execution in `cleanupIncognitoThreads` (`packages/db/index.ts`) avoiding dynamic string interpolation with `sql.raw`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
* Add test for `cleanupIncognitoThreads` * Add tests for graph query parameterization functions
* Added unit test for `cleanupIncognitoThreads` * Added unit test for AST graph query parameterization functions * Updated `vitest.config.ts` to output `lcov` * Added `test:coverage` script to `packages/db` * Resolved memory exhaustion in build output
* Set `v8` coverage provider for vitest and specified `lcov` reporter. * Added `test:coverage` command to `packages/db/package.json` to properly generate metrics in CI pipeline.
|
🛡️ Sentinel: [CRITICAL] Fix injection vulnerabilities
🚨 Severity: CRITICAL
💡 Vulnerability: Direct string interpolation in
falkordbGraph queries anddrizzle-ormraw SQLsql.rawinterpolation that can result in Cypher / SQL Injection.🎯 Impact: Potential unauthorized execution of arbitrary queries on the FalkorDB or PostgreSQL instance.
🔧 Fix: Refactored the methods to pass parameterized inputs correctly to the queries.
✅ Verification: Ran
pnpm lintandpnpm testsuccessfully. Verified that user inputs are passed as explicitparamsreplacing inline strings.PR created automatically by Jules for task 15781562299706880232 started by @ibsukru