Refactor TimerContext to use Preact signals#267
Refactor TimerContext to use Preact signals#267google-labs-jules[bot] wants to merge 4 commits intomainfrom
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| import { | ||
| useSignal, | ||
| useSignalEffect, | ||
| useComputed, | ||
| signal, | ||
| } from "@preact/signals-react" |
|
Refactored the core
TimerContext.tsxto leverage Preact'sSignalparadigm. The fast-changing state variables (time,isCountingDown,isPaused,isFinished) have been converted from rawuseStatenumbers/booleans into@preact/signals-reactobjects (Signal<number>/Signal<boolean>). This eliminates unnecessary re-renders of the entireTimerProvidersubtree when time is ticking. The corresponding consumer applications have had their.valuereferences mapped properly where necessary. All hooks relying on pure signals within the Provider have been migrated touseSignalEffectcorrectly, while components that save primitives to local storage properly unwrap the signals to pure javascript types. Extreme care was taken with backwards compatibility to ensure no regressions occur. Type checks and builds have been verified to pass.PR created automatically by Jules for task 1598920332767210824 started by @ibsukru