Skip to content

Fix commit status update for UI Review when using --skip#474

Merged
ghengeveld merged 7 commits intomainfrom
send-branch-with-skip
Jan 18, 2022
Merged

Fix commit status update for UI Review when using --skip#474
ghengeveld merged 7 commits intomainfrom
send-branch-with-skip

Conversation

@tmeasday
Copy link
Copy Markdown
Member

@tmeasday tmeasday commented Dec 10, 2021

@tmeasday tmeasday requested a review from ghengeveld December 10, 2021 04:31
@tmeasday
Copy link
Copy Markdown
Member Author

The branch has now been merged + released, can we release this change?

@tmeasday tmeasday requested a review from ghengeveld December 20, 2021 06:15
@ghengeveld ghengeveld changed the title Send branch when skipping Send branch and slug when skipping Dec 22, 2021
@tmeasday tmeasday requested a review from ghengeveld January 13, 2022 05:36
@tmeasday
Copy link
Copy Markdown
Member Author

@ghengeveld what is the best way to test this? I pushed the upstream branch https://github.com/chromaui/chromatic/pull/5732 to staging

@ghengeveld
Copy link
Copy Markdown
Member

@ghengeveld what is the best way to test this? I pushed the upstream branch chromaui/chromatic#5732 to staging

You'll need a PR from a fork and then trigger a skipBuild with that ownerName:branchName combo. The --branch-name flag supports that format (it will override the detected slug if you do). Then I guess you can check Loggly for Succesfully synced commit status for UI Review with Skipped build. as the description.

@tmeasday
Copy link
Copy Markdown
Member Author

You'll need a PR from a fork and then trigger a skipBuild with that ownerName:branchName combo. The --branch-name flag supports that format (it will override the detected slug if you do). Then I guess you can check Loggly for Succesfully synced commit status for UI Review with Skipped build. as the description.

Thanks, that's useful, but actually what I just meant is how can I test this branch of the CLI?

@ghengeveld
Copy link
Copy Markdown
Member

Thanks, that's useful, but actually what I just meant is how can I test this branch of the CLI?

Publish it as a canary release. Instructions are in the README.

@tmeasday
Copy link
Copy Markdown
Member Author

Awesome. Worked! Thanks @ghengeveld

image

chromaui/shapes#44

@tmeasday
Copy link
Copy Markdown
Member Author

I'll let you merge + release this @ghengeveld ?

@ghengeveld ghengeveld merged commit 95d305c into main Jan 18, 2022
@ghengeveld ghengeveld deleted the send-branch-with-skip branch January 18, 2022 09:24
@ghengeveld ghengeveld changed the title Send branch and slug when skipping Fix commit status update for UI Review when using --skip Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants