Skip to content

Best effort alternative to tree-kill that swallows errors#1261

Draft
jmhobbs wants to merge 1 commit intomainfrom
jmhobbs/cap-4242-find-a-more-robust-pid-tree-killing-solution
Draft

Best effort alternative to tree-kill that swallows errors#1261
jmhobbs wants to merge 1 commit intomainfrom
jmhobbs/cap-4242-find-a-more-robust-pid-tree-killing-solution

Conversation

@jmhobbs
Copy link
Copy Markdown
Contributor

@jmhobbs jmhobbs commented Mar 30, 2026

Still searching, but I did not find any suitable alternatives yet.

📦 Published PR as canary version: 16.0.1--canary.1261.23762506777.0

✨ Test out this PR locally via:

npm install chromatic@16.0.1--canary.1261.23762506777.0
# or 
yarn add chromatic@16.0.1--canary.1261.23762506777.0

@jmhobbs jmhobbs requested a review from a team March 30, 2026 17:25
@jmhobbs jmhobbs self-assigned this Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

📦 Package Size: 5732 KB
✅ Compared to main: 0 KB c175ff8 (5732 KB)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 10.63830% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (c175ff8) to head (68595ba).

Files with missing lines Patch % Lines
node-src/lib/shell/treeKill.ts 9.75% 37 Missing ⚠️
node-src/lib/shell/shell.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   72.22%   71.86%   -0.36%     
==========================================
  Files         208      209       +1     
  Lines        7918     7963      +45     
  Branches     1435     1435              
==========================================
+ Hits         5719     5723       +4     
- Misses       2177     2218      +41     
  Partials       22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmhobbs jmhobbs force-pushed the jmhobbs/cap-4242-find-a-more-robust-pid-tree-killing-solution branch from 0254939 to 68595ba Compare March 30, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants