Chrivers/apiv1 entertainment mode #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configuration groups
…ment group" in v1 nomenclature)
Previously, entertainment streaming (incoming messages over DTLS) was assumed to be version 2, the modern version that "everybody" uses. Well, it turns out that important clients, such as Philips(!) Ambilight TVs, still stream using the ancient version 1 of the streaming protocol. This change brings support for parsing version 1, and prepares the Bifrost infrastructure for upcoming support for handling version 1 frames.
… not ResourceLink. (Fixes iLightShow disconnects)
… hex (fixes iLightShow not being able to stream)
…ConfigurationLocationsUpdate
…sable from api v1
…es EntertainmentConfigurationLocationsNew
…onal This allows changing entertainment configurations from api v1, which makes iLightShow able to switch targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement complete support for entertainment zones ("sync mode") for the v1 api, including the obsolete (but apparently still used) streaming v1 api!
This fixes support for at least the following:
This change also improves logging and error handling related to sync streaming.